Review of "Glance" version 2

Details Page Preview

Google Calendar events and Meet notifications in the GNOME top bar


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO011 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO016 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:468
            this._calTimerId = GLib.timeout_add_seconds(
                GLib.PRIORITY_DEFAULT, POLL_CALENDAR_S, () => {
                    this._refreshEvents().catch(e => console.error('[Glance]', e.message));
                    return GLib.SOURCE_CONTINUE;
                }
            )
  • extension.js:474
            this._meetTimerId = GLib.timeout_add_seconds(
                GLib.PRIORITY_DEFAULT, CHECK_MEETINGS_S, () => {
                    const { events } = Storage.getEventsCache();
                    this._checkMeetings(events).catch(e => console.error('[Glance]', e.message));
                    return GLib.SO

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

MartoEporedia auto- rejected
Auto-rejected because of new version 3 was uploaded