Review of "Take A Break (Break Reminder)" version 1

Details Page Preview

Reminder to take regular breaks

Extension Homepage
https://github.com/VukV/take-a-break-gnome-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • stylesheet.css
    placeholder stylesheet.css

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:84
            this._durationSlider.connect('notify::value', () => {
                this._updateDurationFromSlider();
            })

EGO014 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:89
            this._durationLabel = new St.Label({
                text: this._formatDurationLabel(this._durationMinutes),
            })

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

VukV posted a review
I don't have proper signal and object disable/destroy implemented. A fixed version will be uploaded after the review.
VukV auto- rejected
Auto-rejected because of new version 2 was uploaded