Review of "adw-gtk3 Colorizer" version 4

Details Page Preview

Colorize adw-gtk3 straight from your system color accents.

Extension Homepage
https://github.com/NiffirgkcaJ/adw-gtk3-colorizer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:300
    GLib.file_get_contents(filePath)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 25 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:31
    console.error(message)
  • extension.js:48
    console.log(`[${this.uuid}] Enabling extension...`)
  • extension.js:56
    console.log(`[${this.uuid}] Accent color setting changed, updating CSS...`)
  • extension.js:67
    console.log(`[${this.uuid}] Disabling extension...`)
  • extension.js:71
    console.log(`[${this.uuid}] Disconnected settings listener.`)
  • extension.js:90
    console.log(`[${this.uuid}] Disable complete.`)
  • extension.js:143
    console.log(`[${this.uuid}] Processing GTK3 CSS...`)
  • extension.js:151
    console.log(`[${this.uuid}] Processing GTK4 CSS...`)
  • extension.js:158
    console.log(`[${this.uuid}] Accent color is custom hex. Removing GTK4 block if present.`)
  • extension.js:184
    console.log(`[${uuid}] Creating directory ${dirPath}...`)

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

All Versions

Version Status
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

dlandau active
Please check shexli messages for next time