GNOME Shell Extensions

Review of "Compiz alike magic lamp effect" version 23

Details Page Preview

Compiz alike magic lamp effect

by hermes83

Magic lamp effect inspired by the Compiz ones NB: In case of update error please restart Gnome Shell (on Xorg press ALT+F2 then write r and press enter, on Wayland end the session and log in again)

Extension Homepage
https://github.com/hermes83/compiz-alike-magic-lamp-effect
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO033 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:46 
    this.effectComboBox = this.addComboBox(group1, "Effect", settingsData.EFFECT)
  • prefs.js:47 
    this.durationSlider = this.addSlider(group1, "Duration (ms)", settingsData.DURATION, 100.0, 1000.0, 0)
  • prefs.js:51 
    this.xTilesSlider = this.addSlider(group2, "X Tiles", settingsData.X_TILES, 3.0, 50.0, 0)
  • prefs.js:52 
    this.yTilesSlider = this.addSlider(group2, "Y Tiles", settingsData.Y_TILES, 3.0, 50.0, 0)

All Versions