Review of "Script Launcher" version 1.1.0 (3)

Details Page Preview

Launch scripts from the top panel with search, pinning, and right-click actions

Extension Homepage
https://github.com/enginyilmaaz/gnome_extension_script_launcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:595
    this._menu = new ScrollableMenu()
  • extension.js:570
        this._searchEntry = new St.Entry({
          style: this._getSearchEntryStyle(239),
          hint_text: t.search_scripts || 'Search scripts...',
          track_hover: true,
          can_focus: true,
        })
  • extension.js:587
        this._searchMenuItem = new PopupMenu.PopupBaseMenuItem({
          reactive: false,
          can_focus: false,
          style_class: '',
        })

All Versions

Version Status
1.1.0 (5) Unreviewed
1.1.0 (4) Rejected
1.1.0 (3) Rejected
1.1.0 (2) Rejected
1.1.0 (1) Rejected

Previous Reviews on this Version

enginyilmaaz auto- rejected
Auto-rejected because of new version 1.1.0 (4) was uploaded