Review of "Google Tasks" version 6

Details Page Preview

A Google Tasks widget in the notification center. This extension is not affiliated, funded, or in any way associated with Google.

Extension Homepage
https://github.com/ZTL-UwU/gnome-shell-google-tasks

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 11 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • tasksManager.js:39
    console.error(`Google Tasks Error: ${e.message}`)
  • tasksManager.js:41
    console.error(`Google Tasks Error: ${e.message}`)
  • tasksManager.js:56
    console.error(`Google Tasks Error: ${e.message}`)
  • tasksManager.js:58
    console.error(`Google Tasks Error: ${e.message}`)
  • tasksManager.js:78
    console.error(`Google Tasks: Failed to fetch tasks for list ${list.title}: ${error instanceof Error ? error.message : String(error)}`)
  • tasksManager.js:86
    console.error(`Google Tasks Error: ${e.message}`)
  • tasksManager.js:89
    console.error(`Google Tasks Error: ${e.message}`)
  • tasksManager.js:114
    console.error(`Google Tasks: Failed to create task: ${e instanceof Error ? e.message : String(e)}`)
  • tasksManager.js:125
    console.error(`Google Tasks: Failed to complete task: ${e instanceof Error ? e.message : String(e)}`)
  • tasksManager.js:136
    console.error(`Google Tasks: Failed to mark task as unfinished: ${e instanceof Error ? e.message : String(e)}`)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:34
        this._descriptionEntry = new St.Entry({
          style_class: 'google-tasks-dialog-entry',
          hint_text: 'Description',
          can_focus: true,
          x_expand: true,
        })
  • extension.js:27
        this._entry = new St.Entry({
          style_class: 'google-tasks-dialog-entry',
          hint_text: 'Task title',
          can_focus: true,
          x_expand: true,
        })
  • extension.js:93
        this._descriptionEntry = new St.Entry({
          style_class: 'google-tasks-dialog-entry',
          hint_text: 'Description (optional)',
          can_focus: true,
          x_expand: true,
        })
  • extension.js:86
        this._entry = new St.Entry({
          style_class: 'google-tasks-dialog-entry',
          hint_text: 'Task title',
          can_focus: true,
          x_expand: true,
        })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:34
        this._descriptionEntry = new St.Entry({
          style_class: 'google-tasks-dialog-entry',
          hint_text: 'Description',
          can_focus: true,
          x_expand: true,
        })
  • extension.js:27
        this._entry = new St.Entry({
          style_class: 'google-tasks-dialog-entry',
          hint_text: 'Task title',
          can_focus: true,
          x_expand: true,
        })
  • extension.js:93
        this._descriptionEntry = new St.Entry({
          style_class: 'google-tasks-dialog-entry',
          hint_text: 'Description (optional)',
          can_focus: true,
          x_expand: true,
        })
  • extension.js:86
        this._entry = new St.Entry({
          style_class: 'google-tasks-dialog-entry',
          hint_text: 'Task title',
          can_focus: true,
          x_expand: true,
        })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:443
        this._tasksSection.connect('add-task-clicked', () => {
          dateMenu.menu.close();
          this._showAddTaskDialog();
        })
  • extension.js:474
        dialog.connect('task-created', (_dialog, title, description) => {
          this._onAddTask(title, description, this._selectedTaskListId ?? undefined);
        })
  • extension.js:731
        dialog.connect('task-updated', async (_dialog, title, description) => {
          if (!this._tasksManager || !task.taskListId)
            return;
          try {
            await this._tasksManager.updateTask(task.taskListId, task.id, title, description);
            this._refreshTasks();
          }
          catch (e) 

All Versions

Version Status
7 Active
6 Rejected
5 Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

ZTL-UwU auto- rejected
Auto-rejected because of new version 7 was uploaded