Review of "OctoPrint Monitor" version 1

Details Page Preview

Monitor your OctoPrint 3D printer from the GNOME panel. Shows print status, progress, and live webcam view.

Extension Homepage
https://github.com/ggilestro/octognome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:98
            this.menu.connect('open-state-changed', (menu, open) => {
                if (open) {
                    this._refreshWebcam();
                }
            })

EGO016 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:672
                    GLib.timeout_add(GLib.PRIORITY_LOW, 5000, () => {
                        try {
                            file.delete(null);
                            scaledFile.delete(null);
                        } catch (e) {
                            // Ignore cleanup errors
                        }
               

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

ggilestro auto- rejected
Auto-rejected because of new version 2 was uploaded