Review of "Xremap" version 15

Details Page Preview

Allow xremap to fetch the focused app name using D-Bus or local socket.

Extension Homepage
https://github.com/xremap/xremap-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:25
    this.dbus = Gio.DBusExportedObject.wrapJSObject(dbus_object, this)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:109
    this._socketService.connect('incoming', this._handleConnection)

All Versions

Version Status
15 Active
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

dlandau active