Review "Caffeine 50" version 1 - GNOME Shell Extensions

Review of "Caffeine 50" version 1

Details Page Preview

Caffeine 50

by enis

Disable the screensaver and auto suspend

Extension Homepage: https://github.com/eonpatapon/gnome-shell-extension-caffeine

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

extension.js:1066
```
this._settings = this.getSettings()
```

extension.js:153

this._appSystem = Shell.AppSystem.get_default()

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

extension.js:1077

    disable() {
        this._caffeineIndicator.destroy();
        this._caffeineIndicator = null;

        // Unregister shortcut
        Main.wm.removeKeybinding(TOGGLE_SHORTCUT);
    }

All Versions

Version	Status
1	Unreviewed