Review of "Top Panel Logo" version 23

Details Page Preview

Adds a customizable button to your top panel, letting you personalize your GNOME desktop with the icon of your choice. Set your preferred icon, adjust its size and position, and decide what happens when you click it! Choose from: - Do Nothing - Show Overview - Show Apps Grid - Hide Visible Windows - Open System Monitor - Launch App - Custom Command - Open Website - Open Folder

Extension Homepage
https://github.com/jmpegi/top-panel-logo

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 13 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:73
    console.log("Icon file not found or invalid: " + finalIconPath)
  • extension.js:83
    console.log("Error loading icon: " + e.message)
  • extension.js:313
    console.log(`Running custom command: ${customCommand}`)
  • extension.js:338
    console.log("No Website URL configured")
  • extension.js:376
                console.log(
                  `Folder does not exist: ${absolutePath}, falling back to home`,
                )
  • extension.js:261
    console.error("Failed to hide/show visible windows:", e)
  • extension.js:269
    console.error("Failed to launch system monitor:", e)
  • extension.js:291
    console.error(`Failed to launch app on ${clickType} click:`, e)
  • extension.js:316
              console.error(
                `Failed to run custom command on ${clickType} click:`,
                e,
              )
  • extension.js:349
    console.error("No default web browser found")

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:176
        this._panelButton.connect("button-press-event", (actor, event) => {
          const button = event.get_button();
          if (button === Clutter.BUTTON_PRIMARY) {
            // Left click action
            const leftClickAction = this._settings.get_int("left-click-action");
            this._handleClickAction(le

All Versions

Version Status
24 Active
23 Rejected
22 Active
21 Active
20 Active
19 Rejected
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

jmpegi posted a review
Hi, v23 changes: Implement bundled 'gnome-foot.svg' icon, improve path conversion logic, add package.sh script Thanks!
jmpegi auto- rejected
Auto-rejected because of new version 24 was uploaded