Review of "LibreLinkUp Top Bar" version 6

Details Page Preview

Show glucose readings from FreeStyle LibreLinkUp in the top bar

Extension Homepage
https://github.com/gfidente/llu-top-bar-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:110
    console.warn("LLU: Configure credentials before use")
  • extension.js:139
    console.warn(`LLU: Login failed with status ${message.status_code}`)
  • extension.js:155
    console.warn("LLU: Token not found in response")
  • extension.js:181
    console.warn("LLU: Token appears expired, retrying login")
  • extension.js:187
    console.warn(`LLU: Fetch failed ${message.status_code}`)
  • extension.js:216
    console.warn("LLU: Data invalid")
  • extension.js:159
    console.error(`LLU: Login exception: ${e}`)
  • extension.js:220
    console.error(`LLU: Parsing error: ${e}`)

All Versions

Version Status
8 Active
7 Inactive
6 Inactive
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

SriramRamkrishna rejected
You have a bunch of logging , can you remove them and then resubmit?
gfidente posted a review
thanks for the review; I converted most of these into .debug messages and will post an update. I think there is value in keeping them but probably only when debugging.
dlandau active
Those warnings didn't originate in this version so I'll approve it now, but look into it for next time