Review of "WindowSwitcher" version 14

Details Page Preview

One windows circle with Alt+tab. Another one with Super+Tab. Keyboard shortcuts see on screenshots

Extension Homepage
https://gitlab.com/tbepdb/window-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:169
    this._appSystem = Shell.AppSystem.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:176
    this._settings.connect('changed', this._updateAppConfigs.bind(this))

All Versions

Version Status
14 Unreviewed
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Rejected
5 Active
4 Rejected
3 Rejected
2 Active
1 Rejected