Review of "Multiple Paste" version 3

Details Page Preview

A lightweight clipboard history manager for GNOME Shell

Extension Homepage
https://github.com/jonis100/gnome-multiple-paste

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:32
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • screenshots/settings.png
    screenshots/settings.png
  • screenshots/history.png
    screenshots/history.png

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:161
          this._searchEntry.clutter_text.connect("text-changed", () =>
            this._filterRows(),
          )
  • extension.js:208
          this.menu.actor.connect("key-press-event", (_actor, event) => {
            const sym = event.get_key_symbol();
            // Ignore navigation / modifier-only keys
            if (
              sym === Clutter.KEY_Up ||
              sym === Clutter.KEY_Down ||
              sym === Clutter.KEY_Return ||
             
  • extension.js:195
          this.menu.connect("open-state-changed", (_m, open) => {
            if (open) {
              this._searchEntry.set_text("");
              this._history.scroll.vadjustment.value = 0;
              // Defer focus so the menu is fully mapped before we grab input
              Meta.later_add(Meta.LaterType.BEFORE_R

All Versions

Version Status
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

yonis100 auto- rejected
Auto-rejected because of new version 4 was uploaded