Review of "Genshin Resin Counter" version v1.0.0 (2)

Details Page Preview

GNOME Shell extension for tracking Genshin Impact resin with countdown timers


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • storage.js:26
    file.load_contents(null)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • replenishCalculator.js
  • types.js

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:39
            this.interval = setInterval(() => {
                this.updateResinNumber();
                this.updateTimers();
            }, 1000)

All Versions

Version Status
v1.1 (3) Unreviewed
v1.0.0 (2) Rejected
v1.0.0 (1) Rejected

Previous Reviews on this Version

SerhiiCho auto- rejected
Auto-rejected because of new version v1.1 (3) was uploaded