Review of "Zephyr Weather" version 1

Details Page Preview

NZ weather station widget powered by Zephyr

Extension Homepage
https://zephyrapp.nz

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:64
            this._panelIcon = new St.Icon({
                icon_name: 'weather-windy-symbolic',
                style_class: 'system-status-icon',
            })
  • extension.js:68
            this._panelLabel = new St.Label({
                text: '',
                y_align: Clutter.ActorAlign.CENTER,
                style_class: 'zephyr-panel-text',
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:64
            this._panelIcon = new St.Icon({
                icon_name: 'weather-windy-symbolic',
                style_class: 'system-status-icon',
            })
  • extension.js:68
            this._panelLabel = new St.Label({
                text: '',
                y_align: Clutter.ActorAlign.CENTER,
                style_class: 'zephyr-panel-text',
            })

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:57
    this._session = new Soup.Session()

All Versions

Version Status
1 Unreviewed