Review of "ApexShot GNOME Integration" version 1

Details Page Preview

Enhances ApexShot with GNOME Shell integration for window stacking, recording masks, and runtime overlays

Extension Homepage
https://github.com/apex-shot/apexshot

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • extension.js:468
    this._dbusObject.run_dispose()

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • runtime-overlays.js:309
    GLib.file_get_contents(path)

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • extension.js:769
    this._previewHelper = new PreviewStackingHelper()
  • extension.js:769
    new PreviewStackingHelper()
  • extension.js:770
    this._maskService = new RecordingMaskService()
  • extension.js:770
    new RecordingMaskService()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:770
    this._maskService = new RecordingMaskService()
  • extension.js:769
    this._previewHelper = new PreviewStackingHelper()

All Versions

Version Status
1 Unreviewed