Panel popup with a list of conference room links (Google Meet, Jitsi, incl. self-hosted). Click to open, button to copy URL. The copy button writes the selected room URL to the clipboard.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
EGO-A-005 manual_review
extensions should not access the clipboard directly
Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.
lib/clipboard.js:5
St.Clipboard.get_default()
| Version | Status |
|---|---|
| 3 | Unreviewed |
| 2 | Active |
| 1 | Rejected |
1. Please add to the description that this extension is using clipboard: [EGO Review Guidelines: Clipboard](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#clipboard-access-must-be-declared) 2. Use `destroy()` instead of `_onDestroy()`. 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 4. Remove `lib/.gitkeep`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 5. Remove line 14 `extension.js`. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Thanks for the review. Version 2 addresses all five points: 1. The extension description now declares the clipboard access. 2. RoomRow overrides destroy() instead of connecting the destroy signal / using _onDestroy(). 3. Signal connections now use connectObject()/disconnectObject() (indicator, roomRow, hotkeys) so handlers are tracked and cleaned up automatically. 4. Removed lib/.gitkeep. 5. Removed the redundant initTranslations() call on line 14 of extension.js (gettext is initialized automatically on Shell 45+). I left out the optional donations key for now, since I don't have a donation method to list.