Review of "Cycle Tiling" version 1

Details Page Preview

Rectangle-like cycling window tiling (25% -> 33% -> 50% ...)


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 15 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:23
    console.log("[Cycle-Tiling] enabled")
  • extension.js:41
    console.log(`[Cycle-Tiling] Removing ${name} from stack.`)
  • extension.js:45
    console.log(`[Cycle-Tiling] Removing overridden ${name} from stack.`)
  • extension.js:53
    console.log("[Cycle-Tiling] disabled")
  • extension.js:75
    console.log(`[Cycle-Tiling] Adding ${name} to stack.`)
  • extension.js:88
    console.log(`[Cycle-Tiling] Adding ${name} to overridinen bindings.`)
  • extension.js:103
    console.log(`[Cycle-Tiling] Cannot get active window.`)
  • extension.js:106
    console.log(`[Cycle-Tiling] ${direction} called for ${win}.`)
  • extension.js:127
    console.log(`[Cycle-Tiling] ${direction} → ${ratio}`)
  • extension.js:164
        console.log(
          `[Cycle-Tiling] ${direction}: (${workArea.width}x${workArea.height}) ${x} ${y} ${width} ${height}`,
        )

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:21
    this._settings = this.getSettings()

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:7
    this._settings = this.getSettings()

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

lordgreg auto- rejected
Auto-rejected because of new version 2 was uploaded