GNOME Shell Extensions

Review of "Nitrokey 3 OTP" version 2

Details Page Preview

Nitrokey 3 OTP

by bonzini

Provide a system menu item to retrieve an OTP from a NitroKey. Pick the desired target from the menu and paste from the clipboard.

Extension Homepage
https://gitlab.com/bonzini/gnome-nk3
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:143 
    St.Clipboard.get_default()

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

bonzini posted a review
Delta from v1: -------------- JS cleanups: - use === - use const instead of var shexli cleanups and fixes: - _nk is now set in enable() and cleared in disable() - all objects and signals now destroyed/disconnected fully in disable() - all objects and signals now cleared fully in disable() - removed redundant console.warn
bonzini auto- rejected
Auto-rejected because of new version 3 was uploaded