Review of "Perfect Fit" version 4

Details Page Preview

Perfect Fit is a lightweight GNOME Shell extension that improves your workflow by automatically centering windows and resizing them to a customizable portion of the screen.

Extension Homepage
https://github.com/yawuxi/perfect-fit

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • extension.js:38
    window.unmaximize(Meta.MaximizeFlags.BOTH)
  • extension.js:48
    window.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
6 Active
5 Rejected
4 Rejected
3 Active
2 Active
1 Active

Previous Reviews on this Version

yawuxi auto- rejected
Auto-rejected because of new version 5 was uploaded