Review of "Rounded Windows - Lite" version 1

Details Page Preview

An opinionated GNOME extension for lightweight, squircle-style window corners.

Extension Homepage
https://github.com/matheus-inacio/rounded-window-corners

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • utils/file.js:12
    file.load_contents(null)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • utils/types.js

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • manager/event_manager.js:61
    globalSignals = new GlobalSignalManager()
  • manager/event_manager.js:61
    new GlobalSignalManager()
  • manager/event_manager.js:62
    actorSignals = new ActorSignalManager()
  • manager/event_manager.js:62
    new ActorSignalManager()

All Versions

Version Status
1 Unreviewed