EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• ddterm/shell/wlclipboard.js:24

  GLib.file_get_contents(`/proc/${pid}/cmdline`)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

• ddterm/app/about.js
• ddterm/app/application.js
• ddterm/app/appwindow.js
• ddterm/app/init.js
• ddterm/app/meta.js
• ddterm/app/notebook.js
• ddterm/app/regex.js
• ddterm/app/search.js
• ddterm/app/tablabel.js
• ddterm/app/tcgetpgrp.js
• ddterm/app/terminal.js
• ddterm/app/terminalpage.js
• ddterm/app/terminalsettings.js
• ddterm/app/urldetect_patterns.js
• ddterm/pref/dialog.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• ddterm/shell/panelicon.js:71

          this.about_item = new PopupMenu.PopupMenuItem(
              gettext_domain.gettext('About ddterm')
          )

• ddterm/shell/panelicon.js:63

          this.preferences_item = new PopupMenu.PopupMenuItem(
              gettext_domain.gettext('Preferences…')
          )

• ddterm/shell/panelicon.js:48

          this.toggle_item = new PopupMenu.PopupSwitchMenuItem(
              gettext_domain.gettext('Show'),
              false
          )

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• ddterm/shell/extension.js:239

  this.settings = this.extension.getSettings()

• ddterm/shell/panelicon.js:71

          this.about_item = new PopupMenu.PopupMenuItem(
              gettext_domain.gettext('About ddterm')
          )

• ddterm/shell/panelicon.js:63

          this.preferences_item = new PopupMenu.PopupMenuItem(
              gettext_domain.gettext('Preferences…')
          )

• ddterm/shell/panelicon.js:48

          this.toggle_item = new PopupMenu.PopupSwitchMenuItem(
              gettext_domain.gettext('Show'),
              false
          )

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• ddterm/shell/extension.js:296

          this.service.connect('error', (service, ex) => {
              const log_collector = service.subprocess?.log_collector;
  
              if (!log_collector) {
                  this.notifications.show_error(ex);
                  return;
              }
  
              log_collector.collect().then(output =

• ddterm/shell/extension.js:285

          this.service.connect('notify::starting', service => {
              if (service.starting) {
                  this.notifications.destroy(
                      MessageTray.NotificationDestroyedReason.EXPIRED
                  );
  
                  if (!this.extension.check_version_match())
             

• ddterm/shell/extension.js:278

          this.service.connect('notify::subprocess', service => {
              const { subprocess } = service;
  
              if (subprocess)
                  this.extension.watch_app_process(subprocess);
          })

• ddterm/shell/extension.js:456

  this.window_manager.connect('hide-request', () => this.app_control.hide(false))

• ddterm/shell/extension.js:377

          this.window_matcher.connect('notify::current-window', () => {
              this.#create_window_manager();
          })

• ddterm/shell/extension.js:387

          this.window_matcher.connect('notify::current-window', () => {
              this.#set_skip_taskbar();
          })