Review of "Wanda The Fish" version 5

Details Page Preview

Wanda the fish is back with her fortune telling powers! Click Wanda to see your fortune and again for it to disappear. As of Gnome Shell 45: You can also right click to see fortune in smaller pop up. Fortune in smaller pop up will stay the same until it is clicked on. If you receive the error: 'Sorry, no wisdom for you today' be sure to install 'fortune-mod'.


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:22
    GLib.spawn_command_line_sync('fortune')

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:58
            this._indicator.connect('button-press-event', (actor, event) => {
                if (event.get_button() === 1) { // 1 is Left Click
                    this.showDialog(wanda);
                    return Clutter.EVENT_STOP;
                }
                else if (event.get_button() === 3) { // 3 is Right Cli
  • extension.js:101
            dialog.connect('button-press-event', (actor, event) => {
                dialog.close();
            })

All Versions

Version Status
7 Active
6 Rejected
5 Rejected
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

k_labrie auto- rejected
Auto-rejected because of new version 6 was uploaded