Review of "Mirror" version 6

Details Page Preview

Mirror Android devices with wireless debugging effortlessly. Note: Requires avahi-browse, qrencode, scrcpy, and adb to be installed. See the README on GitHub for more information. If you encounter bugs or issues, please report them on GitHub.

Extension Homepage
https://github.com/TheRealSourcer/mirror

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:110
          dialog.connect('closed', () => {
            if (this._pairingPollTimeoutId) {
                GLib.source_remove(this._pairingPollTimeoutId);
                this._pairingPollTimeoutId = null;
            }
            this._pairingActive = false;
            dialog.destroy();
            this._pairingDialog = null;
       

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:290
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, ms, () => {
              resolve();
              return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
8 Active
7 Rejected
6 Rejected
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

distro auto- rejected
Auto-rejected because of new version 7 was uploaded