Review of "WarpGnome" version 1

Details Page Preview

Toggle Cloudflare WARP in quick settings. Forked by unaibenidorm (original author: khaled-0, thank you!). This extension depends on warp-cli parsing. To quickly get started, Read the Docs: https://github.com/unaibenidorm/WarpGnome#readme This extension is not affiliated, funded, or in any way associated with Cloudflare. To Setup warp-cli, follow the official guide: https://developers.cloudflare.com/warp-client/get-started/linux/

Extension Homepage
https://github.com/unaibenidorm/WarpGnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • package-lock.json
    package-lock.json

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.cloudflare-warp-toggle.gschema.xml
    id='org.gnome.shell.extensions.cloudflare-warp-toggle.gschema' path='/org/gnome/shell/extensions/cloudflare-warp-toggle/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:19
        this._settings.connect("changed", (settings) => {
          if (settings.get_boolean("status-check")) {
            this.startStatusCheckLoop();
          } else {
            if (this._interval) clearInterval(this._interval);
          }
        })
  • indicator.js:107
          this.menu.connect("open-state-changed", (menu, open) => {
            if (open) {
              this._updateSettings();
            }
          })

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

unaibenidorm auto- rejected
Auto-rejected because of new version 2 was uploaded