EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

• appMixer.js:128

                      GLib.spawn_command_line_sync(
                          `pactl move-sink-input ${this._sinkInputIndex} ${sink.id}`)

• portSettings.js:169

  GLib.spawn_sync(
              null, ['pactl', 'list', 'cards'], env,
              GLib.SpawnFlags.SEARCH_PATH, null)

• portSettings.js:124

  GLib.spawn_command_line_sync('pactl list sinks')

• portSettings.js:150

  GLib.spawn_command_line_sync(
                      `${pythonExec} ${pyLocation}`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

• locale/fr/LC_MESSAGES/sound-output-device-chooser.po

  locale/fr/LC_MESSAGES/sound-output-device-chooser.po

• locale/zh_CN/LC_MESSAGES/sound-output-device-chooser.po

  locale/zh_CN/LC_MESSAGES/sound-output-device-chooser.po

• locale/cs_CZ/LC_MESSAGES/sound-output-device-chooser.po

  locale/cs_CZ/LC_MESSAGES/sound-output-device-chooser.po

• locale/ko/LC_MESSAGES/sound-output-device-chooser.po

  locale/ko/LC_MESSAGES/sound-output-device-chooser.po

• locale/nl/LC_MESSAGES/sound-output-device-chooser.po

  locale/nl/LC_MESSAGES/sound-output-device-chooser.po

• locale/sk/LC_MESSAGES/sound-output-device-chooser.po

  locale/sk/LC_MESSAGES/sound-output-device-chooser.po

• locale/de_DE/LC_MESSAGES/sound-output-device-chooser.po

  locale/de_DE/LC_MESSAGES/sound-output-device-chooser.po

• locale/it_IT/LC_MESSAGES/sound-output-device-chooser.po

  locale/it_IT/LC_MESSAGES/sound-output-device-chooser.po

• locale/sv/LC_MESSAGES/sound-output-device-chooser.po

  locale/sv/LC_MESSAGES/sound-output-device-chooser.po

• locale/ta/LC_MESSAGES/sound-output-device-chooser.po

  locale/ta/LC_MESSAGES/sound-output-device-chooser.po

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• appMixer.js:76

          this._sliderChangedId = this._slider.connect('notify::value', () => {
              let newVol = this._slider.value * this._getMaxVolume();
              this._stream.volume = newVol;
              this._stream.push_volume();
          })