Review of "Lilypad Top Bar Manager" version 1.2.3 (16)

Details Page Preview

Organize, hide, and reorder top bar icons - auto collapse timer - button to toggle icon visibility - reorder items by drag and drop - support for non-GTK native apps (eg. Discord, Slack) - support for tablets and touchscreens *right-click to access settings menu

Extension Homepage
https://github.com/shendrew/Lilypad

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:168
    this._indicator.connect('button-press-event', (actor, event) => _onClick(event))
  • extension.js:166
    this._indicator._clickGesture.connect('recognize', _onClick)
  • extension.js:170
                this._indicator.connect('touch-event', (actor, event) => {
                    // only handle initial tap
                    switch (event.type()) {
                        case Clutter.EventType.TOUCH_BEGIN:
                            if (!this._updateIndicatorVisibility())     // indicator is hidden

All Versions

Version Status
1.2.3 (16) Unreviewed
1.2.2 (15) Active
1.2.1 (14) Active
1.2.0 (13) Inactive
1.1.2 (12) Inactive
1.1.1 (11) Inactive
1.1.0 (10) Rejected
1.1.0 (9) Rejected
1.0.5 (8) Inactive
1.0.4 (7) Inactive
1.0.3 (6) Inactive
1.0.2 (5) Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

shendrew posted a review
Note to reviewers: this version fixes an event signal that Gnome 50 deprecated. Signals connected to _indicator should be disconnected by PanelMenu.Button.destroy() in disable().