Review of "Pangolin VPN Status" version 1

Details Page Preview

Status indicator and quick toggle for the Pangolin VPN client

Extension Homepage
https://github.com/arminwinkt/pangolin-gnome-status-indicator

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:80
    GLib.spawn_command_line_sync(
                        `${PANGOLIN_BINARY} status --json`
                    )
  • extension.js:187
    GLib.spawn_command_line_sync(
                    `${PANGOLIN_BINARY} status --json`
                )

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • .gitignore
    .gitignore

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:56
                    GLib.timeout_add(GLib.PRIORITY_DEFAULT, 500, () => {
                        this._spawnCommand(
                            ['ptyxis', '--', PANGOLIN_BINARY, 'up'],
                            () => this._rapidPoll()
                        );
                        return GLib.SOURCE_REMOVE;
            
  • extension.js:77
            GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 2, () => {
                attempts++;
                try {
                    const [, stdout, , exitStatus] = GLib.spawn_command_line_sync(
                        `${PANGOLIN_BINARY} status --json`
                    );
                    const output = new Tex

All Versions

Version Status
1 Unreviewed