Review of "OSTree Status" version 5

Details Page Preview

Show rpm-ostree status in the GNOME.

Extension Homepage
https://github.com/noobping/ostree-status-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:17
                this._button = new St.Button({
                    style_class: 'panel-button',
                    can_focus: true,
                })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:27
                this._button.connect('button-press-event', () => {
                    this._updateState();
                })

All Versions

Version Status
6 Active
5 Rejected
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

noobping auto- rejected
Auto-rejected because of new version 6 was uploaded