Review of "Compact Launcher" version 3

Details Page Preview

Compact popup launcher for GNOME Shell

Extension Homepage
https://github.com/gilson-fonsaca/compact-launcher.git

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. 2. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 3. Timeout should be removed on destroy and also before creating a new one (line 503, 783 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 4. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 5. What's the reason for going over another extension's `extension.js` file (line 839 `extension.js`)? You shouldn't really do that from your extension. 6. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions