Review of "Parasocial" version 1

Details Page Preview

A panel showing whether your favorite streamers are streaming on Twitch and Kick. Parasocial is a extension that shows a panel indicator when your favorite streamers are live on Twitch and Kick. Click the panel to open a dropdown menu with live streamers, viewer counts, game titles, and stream titles. You can launch the stream with a custom command – streamlink, your browser, or any other program. It is a fork of the original TwitchLive Panel by Maweki.

Extension Homepage
https://github.com/corngoblin/Parasocial

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • api.js:41
    tokenfile.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:220
    entry.item.connect("activate", () => this._execCmd(entry.login, entry.platform))
  • extension.js:89
    this.menu.connect('open-state-changed', this._onMenuOpened.bind(this))
  • extension.js:94
    this.notification_source.connect('destroy', () => { this.notification_source = null; })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:129
          this.timer.settings = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 1000, () => {
            this.timer.settings = 0;
            this.updateData();
            return GLib.SOURCE_REMOVE;
          })

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:288
          this.timer.view = GLib.timeout_add(GLib.PRIORITY_DEFAULT, VIEW_UPDATE_INTERVAL, () => {
            this.interval();
            return GLib.SOURCE_CONTINUE;
          })

All Versions

Version Status
1 Unreviewed