Review of "Focus Lock" version 6

Details Page Preview

Lock focus to a specific application window. When enabled, you cannot switch to other windows until you unlock.

Extension Homepage
https://github.com/kavindamihiran/Linux-Focus

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:42
            this._label = new St.Label({
                text: UNLOCKED_ICON,
                y_align: Clutter.ActorAlign.CENTER,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:49
            this._button.connect('clicked', () => {
                this._toggleLock();
            })

All Versions

Version Status
7 Active
6 Rejected
5 Inactive
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

kavinda_mihiran auto- rejected
Auto-rejected because of new version 7 was uploaded