Review of "Public IP address" version 16

Details Page Preview

Shows an public IPv4 and IPv6 address. It uses 'lookup.test-ipv6.com' service to get the public address.

Extension Homepage
https://github.com/Fire-man-x/Public-IP-address---Gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:66
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:24
    		this.panelMenuButton.menu.connect('open-state-changed', (actor, event) => {
    			this.panelMenuButton.menu.removeAll();
    
    			let menuItem;
    			menuItem = new PublicIpPopupMenuItem("IPv4:");
    			this.panelMenuButton.menu.addMenuItem(menuItem);
    			menuItem = new PublicIpPopupMenuItem("IPv6:");
    			this.pa

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:69
    this._httpSession = new Soup.Session()

All Versions

Version Status
20 Active
19 Rejected
18 Active
17 Active
16 Rejected
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

Fire-man-x auto- rejected
Auto-rejected because of new version 17 was uploaded