Review of "Drafts" version 5

Details Page Preview

A quick notepad in the top bar

Extension Homepage
https://github.com/thiagoaciole/drafts-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • ui/main.js:363
    St.Clipboard.get_default()
  • ui/main.js:373
    St.Clipboard.get_default()
  • ui/main.js:390
    St.Clipboard.get_default()
  • ui/main.js:399
    St.Clipboard.get_default()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • ui/main.js:433
    console.error("Drafts: failed to load initial state", error)
  • ui/main.js:477
    console.error("Drafts: failed to archive current draft", error)
  • ui/main.js:507
    console.error("Drafts: failed to open note", error)
  • ui/main.js:570
    console.error("Drafts: failed to refresh history", error)
  • ui/main.js:589
    console.error("Drafts: failed to trim history", error)
  • ui/main.js:609
    console.error("Drafts: failed to autosave draft", error)
  • ui/main.js:706
    console.error("Drafts: failed to save draft on destroy", error)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

Thiago Aciole auto- rejected
Auto-rejected because of new version 6 was uploaded