Review of "Better Quick Settings" version 2

Details Page Preview

beQS: Better Quick Settings. A powerful extension to tweak and enhance GNOME's Quick Settings.

Extension Homepage
https://github.com/unaibenidorm/beQS

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • features/widget/media.js:736
    this._marqueeTitle = new MarqueeLabel({ style_class: titleLabel.style_class || "message-title", x_expand: true })
  • features/widget/media.js:695
    this._progressControl = ctrl

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • features/widget/media.js:736
    this._marqueeTitle = new MarqueeLabel({ style_class: titleLabel.style_class || "message-title", x_expand: true })
  • features/widget/media.js:695
    this._progressControl = ctrl

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • features/widget/media.js:148
            this._idleId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                if (this.mapped && this._enabled) this._start();
                this._idleId = 0;
                return GLib.SOURCE_REMOVE;
            })
  • features/widget/media.js:164
            this._scrollId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 30, () => {
                pos += 0.5 * dir;
                if (pos >= max + 20) { dir = -1; return GLib.SOURCE_CONTINUE; }
                if (pos <= -20)      { dir =  1; return GLib.SOURCE_CONTINUE; }
                adj.set_value(Math.max(0, Mat
  • features/widget/media.js:716
            this._marqueeIdleId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                this._setupMarquee();
                this._marqueeIdleId = 0;
                return GLib.SOURCE_REMOVE;
            })
  • features/widget/media.js:1116
                this._emptyTimeoutId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 800, () => {
                    this.visible = false; this._emptyTimeoutId = 0; return GLib.SOURCE_REMOVE;
                })

All Versions

Version Status
5 Unreviewed
4 Rejected
3 Rejected
2 Rejected
1 Unreviewed

Previous Reviews on this Version

unaibenidorm auto- rejected
Auto-rejected because of new version 3 was uploaded