Review of "Search Light 50" version 1

Details Page Preview

A simple search bar for GNOME 50. ctrl + space to open the search bar repo: https://github.com/Apwlp/search-bar-g50


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:48
        this._entry = new St.Entry({
          hint_text: "Buscar aplicación...",
          can_focus: true,
          style_class: "search-entry",
        })
  • extension.js:54
        this._resultsBin = new St.BoxLayout({
          vertical: true,
          style_class: "results-list",
        })
  • extension.js:231
    button

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:48
        this._entry = new St.Entry({
          hint_text: "Buscar aplicación...",
          can_focus: true,
          style_class: "search-entry",
        })
  • extension.js:54
        this._resultsBin = new St.BoxLayout({
          vertical: true,
          style_class: "results-list",
        })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:92
        this._container.connect("scroll-event", (actor, event) => {
          let direction = event.get_scroll_direction();
          if (direction === Clutter.ScrollDirection.UP) {
            this._selectPrevious();
          } else if (direction === Clutter.ScrollDirection.DOWN) {
            this._selectNext();
          }
  • extension.js:65
        this._entry.clutter_text.connect("key-press-event", (actor, event) => {
          let symbol = event.get_key_symbol();
    
          if (symbol === Clutter.KEY_Escape) {
            this._destroySearch();
            return Clutter.EVENT_STOP;
          } else if (symbol === Clutter.KEY_Down) {
            this._selectNex
  • extension.js:60
        this._entry.clutter_text.connect("notify::text", () => {
          this._updateResults(this._entry.get_text());
        })

All Versions

Version Status
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Apwlp auto- rejected
Auto-rejected because of new version 2 was uploaded