Review of "HAControlPanel" version 10

Details Page Preview

Home Assistant control panel in the GNOME top bar — color picker with copy-to-clipboard, slider, and configurable action buttons.

Extension Homepage
https://github.com/friedjof/HAControlPanel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • lib/ha/haWebSocket.js:107
    console.error('[HAControlPanel] WS connect failed:', e.message)
  • lib/ha/haWebSocket.js:123
    console.error('[HAControlPanel] WS message parse error:', e.message)
  • lib/ha/haWebSocket.js:134
    console.error('[HAControlPanel] WS error:', err.message)
  • lib/ha/haWebSocket.js:139
    console.error('[HAControlPanel] WS setup failed:', e.message)
  • lib/ha/haWebSocket.js:162
    console.error('[HAControlPanel] WS: authentication rejected')
  • lib/ha/haWebSocket.js:173
    console.error('[HAControlPanel] WS callback failed:', e.message)
  • lib/ha/haWebSocket.js:188
    console.error('[HAControlPanel] WS send failed:', e.message)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/sync/colorHistory.js:52
    GLib.file_get_contents(getHistoryPath())

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • ui/colorSection.js:536
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
12 Unreviewed
11 Rejected
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Friedjof auto- rejected
Auto-rejected because of new version 11 was uploaded