Review of "Codex Usage Indicator" version 1

Details Page Preview

Shows current Codex Balance usage in the GNOME top bar.

Extension Homepage
https://github.com/radoslavdodek/codex-usage-gnome-shell-ext

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:108
    this._indicator = new CodexUsageIndicator()

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:346
            this._refreshStartIdleId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                this._refreshStartIdleId = 0;
                if (this._source && shouldStartRefresh(this._config))
                    this._refresh();
                return GLib.SOURCE_REMOVE;
            })
  • extension.js:236
            this._refreshTimerId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, this._config.refreshIntervalSeconds, () => {
                if (!shouldStartRefresh(this._config)) {
                    this._refreshTimerId = 0;
                    return GLib.SOURCE_REMOVE;
                }
                this._refres
  • extension.js:363
            this._renderIdleId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                this._renderIdleId = 0;
                if (this._indicator && this._hasQueuedRender)
                    this._render(this._queuedRenderSnapshot);
                this._queuedRenderSnapshot = null;
                this._hasQueued
  • extension.js:183
            this._settingsChangedIdleId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                this._settingsChangedIdleId = 0;
                if (this._settings)
                    this._onSettingsChanged();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

radosdesign auto- rejected
Auto-rejected because of new version 2 was uploaded