Review of "Reminder Pro" version 1

Details Page Preview

Prayer, Water, and Break reminders for GNOME Shell

Extension Homepage
https://github.com/talhasiddique7/pro-reminder

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:163
            this._currentPrayerItem = new PopupMenu.PopupMenuItem(_('Current prayer: not available'), {
                reactive: false,
            })
  • extension.js:123
                this._iconContainer = new St.Widget({
                    layout_manager: new Clutter.BinLayout(),
                    x_expand: false,
                    y_expand: false,
                })
  • extension.js:110
                this._mainIcon = new St.Icon({
                    gicon: fileIcon,
                    fallback_icon_name: 'appointment-soon-symbolic',
                    style_class: 'system-status-icon',
                    icon_size: 20,
                })
  • extension.js:132
                this._panelText = new St.Label({
                    text: _('No events'),
                    style_class: 'panel-label',
                })
  • extension.js:116
                this._reminderDot = new St.Widget({
                    visible: false,
                    x_align: Clutter.ActorAlign.END,
                    y_align: Clutter.ActorAlign.START,
                    style: 'background-color: #facc15; min-width: 7px; min-height: 7px; border-radius: 99px; border: 1px sol
  • extension.js:153
            this._statusItem = new PopupMenu.PopupMenuItem(_('No reminders scheduled'), {
                reactive: false,
            })
  • extension.js:168
            this._upcomingPrayerItem = new PopupMenu.PopupMenuItem(_('Next prayer: not available'), {
                reactive: false,
            })
  • extension.js:158
            this._upcomingReminderItem = new PopupMenu.PopupMenuItem(_('Upcoming reminder: none'), {
                reactive: false,
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:163
            this._currentPrayerItem = new PopupMenu.PopupMenuItem(_('Current prayer: not available'), {
                reactive: false,
            })
  • extension.js:123
                this._iconContainer = new St.Widget({
                    layout_manager: new Clutter.BinLayout(),
                    x_expand: false,
                    y_expand: false,
                })
  • extension.js:110
                this._mainIcon = new St.Icon({
                    gicon: fileIcon,
                    fallback_icon_name: 'appointment-soon-symbolic',
                    style_class: 'system-status-icon',
                    icon_size: 20,
                })
  • extension.js:132
                this._panelText = new St.Label({
                    text: _('No events'),
                    style_class: 'panel-label',
                })
  • extension.js:116
                this._reminderDot = new St.Widget({
                    visible: false,
                    x_align: Clutter.ActorAlign.END,
                    y_align: Clutter.ActorAlign.START,
                    style: 'background-color: #facc15; min-width: 7px; min-height: 7px; border-radius: 99px; border: 1px sol
  • extension.js:153
            this._statusItem = new PopupMenu.PopupMenuItem(_('No reminders scheduled'), {
                reactive: false,
            })
  • extension.js:168
            this._upcomingPrayerItem = new PopupMenu.PopupMenuItem(_('Next prayer: not available'), {
                reactive: false,
            })
  • extension.js:158
            this._upcomingReminderItem = new PopupMenu.PopupMenuItem(_('Upcoming reminder: none'), {
                reactive: false,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:140
                this._indicator.menu.connect('open-state-changed', (_menu, isOpen) => {
                    if (isOpen)
                        this._markNotificationRead();
                })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

Talha Siddique auto- rejected
Auto-rejected because of new version 2 was uploaded