Review of "NordGnome" version 1

Details Page Preview

Toggle NordVPN in quick settings. This extension depends on nordvpn CLI. Read the Docs: https://github.com/unaibenidorm/NordGnome#readme This extension is not affiliated, funded, or in any way associated with NordVPN. To Setup NordVPN, follow the official guide: https://support.nordvpn.com/hc/es/articles/20196094470929-Instalar-NordVPN-en-distribuciones-de-Linux

Extension Homepage
https://github.com/unaibenidorm/NordGnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • indicator.js:409
              item.menu.connect("open-state-changed", async (_menu, open) => {
                if (!open || item._citiesLoaded) return;
                item._citiesLoaded = true;
    
                try {
                  const citiesOut = await this._runCommand(["nordvpn", "cities", country]);
                  const cities

All Versions

Version Status
1 Active

Previous Reviews on this Version

JustPerfection active
Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions