Review "NordGnome" version 1 - GNOME Shell Extensions

Review of "NordGnome" version 1

Details Page Preview

NordGnome

by unaibenidorm

Toggle NordVPN in quick settings. This extension depends on nordvpn CLI. Read the Docs: https://github.com/unaibenidorm/NordGnome#readme This extension is not affiliated, funded, or in any way associated with NordVPN. To Setup NordVPN, follow the official guide: https://support.nordvpn.com/hc/es/articles/20196094470929-Instalar-NordVPN-en-distribuciones-de-Linux

Extension Homepage: https://github.com/unaibenidorm/NordGnome

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

indicator.js:409

          item.menu.connect("open-state-changed", async (_menu, open) => {
            if (!open || item._citiesLoaded) return;
            item._citiesLoaded = true;

            try {
              const citiesOut = await this._runCommand(["nordvpn", "cities", country]);
              const cities

All Versions

Version	Status
1	Unreviewed