Review of "Open Orpheus Tray Lyrics" version 1

Details Page Preview

Show Open Orpheus lyrics in the GNOME top panel.

Extension Homepage
https://github.com/myouo/open-orpheus-tray-lyrics

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:285
    GLib.file_get_contents(candidate.statePath)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:257
              runtime.monitor.connect("changed", (_monitor, file) => {
                if (file.get_basename() !== STATE_FILE_NAME) return;
                this._queueReadState(runtime);
              })

All Versions

Version Status
1 Unreviewed