Review of "Aura Dock" version 1

Details Page Preview

A centered, minimal GNOME dock with acrylic blur, rounded corners, workspace awareness, and dynamic accent colors.


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:137
            this._appBox = new St.BoxLayout({
                style_class: 'aura-dock-apps',
                clip_to_allocation: false,
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:123
            this._appScrollView = new St.ScrollView({
                style_class: 'aura-dock-app-scroll',
                clip_to_allocation: true,
                reactive: true,
                x_expand: true,
                y_align: Clutter.ActorAlign.CENTER,
                hscrollbar_policy: St.PolicyType.EXTERNAL,
        
  • extension.js:99
            this._backplate = new St.Widget({
                style_class: 'aura-dock-backplate',
                clip_to_allocation: true,
                x_align: Clutter.ActorAlign.FILL,
                y_align: Clutter.ActorAlign.FILL,
            })
  • extension.js:152
    this._menuManager = new PopupMenu.PopupMenuManager(this._dock)
  • extension.js:118
            this._separator = new St.Widget({
                style_class: 'aura-dock-separator',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:106
            this._surface = new St.BoxLayout({
                style_class: 'aura-dock-surface',
                clip_to_allocation: true,
                x_align: Clutter.ActorAlign.FILL,
                y_align: Clutter.ActorAlign.FILL,
            })
  • extension.js:113
            this._workspaceBox = new St.BoxLayout({
                style_class: 'aura-dock-workspaces',
                y_align: Clutter.ActorAlign.CENTER,
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:118
            this._separator = new St.Widget({
                style_class: 'aura-dock-separator',
                y_align: Clutter.ActorAlign.CENTER,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:134
            this._appScrollView.connect('scroll-event',
                (_actor, event) => this._onAppScrollEvent(event))
  • extension.js:153
            this._dock.connect('button-press-event', (_actor, event) => {
                if (event.get_button() !== 3)
                    return Clutter.EVENT_PROPAGATE;
    
                this._openPreferences();
                return Clutter.EVENT_STOP;
            })
  • extension.js:546
                button.connect('destroy', () => {
                    for (const id of [beginId, endId, cancelId]) {
                        if (id)
                            draggable.disconnect(id);
                    }
                    draggable.destroy?.();
                })

All Versions

Version Status
1 Unreviewed