Review of "Screenshot Annotator" version 2

Details Page Preview

Edit your screenshots. Includes paint, OCR, censoring and is designed to be easy to use. First, you need to setup the folder where your screenshots are stored. For this, open the extension settings before using the extension.

Extension Homepage
https://github.com/InledGroup/screenshot-annotator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 10 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:74
            console.error(
              `[Screenshot Annotator] Configured path does not exist: ${savedPath}`,
            )
  • extension.js:164
          console.error(
            `[Screenshot Annotator] CRITICAL: Editor script not found at ${editorPath}`,
          )
  • extension.js:189
              console.error(
                `[Screenshot Annotator] Editor process failed: ${e.message}`,
              )
  • extension.js:205
                  console.error(
                    `[Screenshot Annotator] Editor STDERR: ${decoder.decode(bytes.toArray())}`,
                  )
  • extension.js:212
    console.error(`[Screenshot Annotator] Spawn error: ${e.message}`)
  • extension.js:21
    console.log(`[Screenshot Annotator] v29 enabled`)
  • extension.js:99
        console.log(
          `[Screenshot Annotator] Monitoring: ${screenshotDir.get_path()}`,
        )
  • extension.js:137
              console.log(
                `[Screenshot Annotator] New screenshot detected: ${path}`,
              )
  • extension.js:170
        console.log(
          `[Screenshot Annotator] Launching editor: ${editorPath} with image: ${imagePath}`,
        )
  • extension.js:185
              console.log(
                `[Screenshot Annotator] Editor process exited successfully.`,
              )

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • editor/main.js
  • editor/ui/assets/fabric.min.js
  • editor/ui/script.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:107
        this._monitor.connect("changed", (monitor, file, otherFile, eventType) => {
          const path = file.get_path();
          const fileName = file.get_basename();
          const now = Date.now();
    
          if (fileName.startsWith(".")) return;
    
          // Check ignore list immediately
          if (this._ignoredPa

All Versions

Version Status
2 Unreviewed
1 Rejected