Review of "Bar Enhanced" version 1

Details Page Preview

Reinventa la Barra Superior de GNOME con una interfaz equilibrada, controles visuales y temas listos para el futuro. Diseño limpio, componentes simétricos y una experiencia de configuración moderna.

Extension Homepage
https://github.com/mrvanguardia/bar-enhanced

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-X-005 warning

extensions should not manually load the default stylesheet.css

Extensions should not manually load or unload the default `stylesheet.css`; GNOME Shell handles it automatically.

`stylesheet.css`

  • extension.js:250
    theme.load_stylesheet(stylesheet)
  • extension.js:239
    theme.unload_stylesheet(stylesheet)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 15 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • stylesheets.js:953
    console.error('Error creating gtk config directory: ' + e)
  • stylesheets.js:974
    console.error('Error reading gtk.css: ' + e)
  • stylesheets.js:985
    console.error('Error restoring gtk.css from backup: ' + e)
  • stylesheets.js:993
    console.error('Error deleting BarEnhanced gtk.css: ' + e)
  • stylesheets.js:1004
    console.error('Error backing up gtk.css: ' + e)
  • stylesheets.js:1038
    console.error('Error creating flatpak override directory: ' + e)
  • stylesheets.js:1051
    console.error('Error creating flatpak override global file: ' + e)
  • stylesheets.js:1059
    console.error('Error loading flatpak override global file: ' + e)
  • stylesheets.js:1080
    console.error('Error saving flatpak override global file: ' + e)
  • stylesheets.js:70
    console.log("Failed to write calendar-today.svg file: " + svgpath, e)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • locale/es/LC_MESSAGES/bar-enhanced.po
    locale/es/LC_MESSAGES/bar-enhanced.po

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:1068
    this._connections.connect(Main.layoutManager._bgManagers[pMonitorIdx], 'changed', this.updateBguri.bind(this))
  • extension.js:1069
    this._connections.connect(this._bgSettings, 'changed::picture-uri', this.updateBguri.bind(this))
  • extension.js:1070
    this._connections.connect(this._bgSettings, 'changed::picture-uri-dark', this.updateBguri.bind(this))
  • extension.js:1071
    this._connections.connect(this._intSettings, 'changed::color-scheme', this.updatePanelStyle.bind(this), 'color-scheme')
  • extension.js:1295
    this._connections.connect(btn.child, 'notify::visible', this.updateFittsWidgetVisible.bind(this, btn))
  • extension.js:1340
    this._connections.connect(box, this.addedSignal, this.updateFittsWidgetAddRemove.bind(this))
  • extension.js:1341
    this._connections.connect(box, this.removedSignal, this.updateFittsWidgetAddRemove.bind(this))
  • extension.js:377
                                this._connections.connect(sectionList, this.addedSignal, (container, actor) => {
                                    // console.log('section added: ', actor.constructor.name);
                                    this.applySectionStyles(sectionList, add);
                             
  • extension.js:798
    this._connections.connect(panelColumn, this.addedSignal, this.updatePanelStyle.bind(this))
  • extension.js:800
            this._connections.connect(menu.box, this.addedSignal, (obj, signal, panelColumn, callbk_param) => {
                this._connections.connect(panelColumn, this.addedSignal, this.updatePanelStyle.bind(this));
            })
  • extension.js:801
    this._connections.connect(panelColumn, this.addedSignal, this.updatePanelStyle.bind(this))
  • extension.js:964
    this._connections.connect(global.window_group, this.addedSignal, this.onWindowAdded.bind(this))
  • extension.js:965
    this._connections.connect(global.window_group, this.removedSignal, this.onWindowRemoved.bind(this))
  • extension.js:1419
            this._settings.connect('changed', (settings, key) => {
                this.updatePanelStyle(settings, key);
            })
  • extension.js:1142
                btn.FittsWidget.connect('captured-event', (actor, event) => {
                    btn.child.event(event, false);
                    return Clutter.EVENT_PROPAGATE;
                })
  • extension.js:1132
                btn.FittsWidget.connect('enter-event', (actor, event) => {
                    btn.child.add_style_pseudo_class('hover');
                    return Clutter.EVENT_PROPAGATE;
                })
  • extension.js:1136
                btn.FittsWidget.connect('leave-event', (actor, event) => {
                    btn.child.remove_style_pseudo_class('hover');
                    return Clutter.EVENT_PROPAGATE;
                })
  • extension.js:62
                obj.connect('destroy', () => {
                    this.removeObject(obj)
                })

All Versions

Version Status
4.5.0 (3) Unreviewed
4.5.0 (2) Rejected
1 Rejected

Previous Reviews on this Version

MrVanguardia auto- rejected
Auto-rejected because of new version 4.5.0 (2) was uploaded