Review of "Habit Streak Tracker" version 3

Details Page Preview

A clean GNOME Shell habit tracker with daily streaks, add/edit/delete, and history.

Extension Homepage
https://github.com/talhasiddique7/habit-tracker

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:428
          this._emojiGrid = new St.BoxLayout({
            vertical: true,
            style_class: "habit-emoji-grid",
          })
  • extension.js:411
          this._searchEntry = new St.Entry({
            hint_text: "Search emojis...",
            can_focus: true,
            style_class: "habit-emoji-search",
            x_expand: true,
          })
  • extension.js:673
          this._emojiGrid = new St.BoxLayout({
            vertical: true,
            style_class: "habit-emoji-grid",
          })
  • extension.js:667
          this._emojiScroll = new St.ScrollView({
            style_class: "habit-emoji-scroll habit-emoji-scroll-inline",
            x_expand: true,
            y_expand: true,
            visible: false,
          })
  • extension.js:655
          this._emojiSearch = new St.Entry({
            hint_text: "Search all emojis...",
            can_focus: true,
            style_class: "habit-emoji-search",
            x_expand: true,
            visible: false,
          })
  • extension.js:565
          this._entry = new St.Entry({
            text: habit?.name ?? "",
            hint_text: "New Habit",
            can_focus: true,
            style_class: "habit-entry",
            x_expand: true,
          })
  • extension.js:548
          this._preview = new St.Label({
            text: this._icon,
            style_class: "habit-big-icon",
          })
  • extension.js:598
    this._quickColorRow = colorRow
  • extension.js:649
    emojiRow
  • extension.js:976
          this._calendarBox = new St.BoxLayout({
            vertical: true,
            style_class: "habit-calendar",
          })
  • extension.js:918
          this._iconLabel = new St.Label({
            text: habit.icon,
            style_class: "habit-history-icon",
          })
  • extension.js:944
          this._monthLabel = new St.Label({
            text: this._viewDate.toLocaleString(undefined, {
              month: "long",
              year: "numeric",
            }),
            style_class: "habit-month",
            x_expand: true,
            x_align: Clutter.ActorAlign.CENTER,
          })
  • extension.js:926
          this._nameLabel = new St.Label({
            text: habit.name,
            style_class: "habit-history-name",
          })
  • extension.js:931
          this._streakLabel = new St.Label({
            text: `${currentStreak(habit)} day streak`,
            style_class: "habit-history-streak",
          })

All Versions

Version Status
9 Unreviewed
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Talha Siddique auto- rejected
Auto-rejected because of new version 4 was uploaded