Review of "Quick DNS" version 1

Details Page Preview

Quickly switch DNS servers from GNOME quick settings

Extension Homepage
https://github.com/nolune/quick-dns

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:233
            this._toggle.connect('clicked', () => {
                this._state.enabled = this._toggle.checked;
                this._applyDNS();
            })
  • extension.js:223
            this._toggle.connect('preset-selected', (t, id) => {
                this._state.preset = id;
                this._toggle.setActivePreset(id);
                if (!this._state.enabled) {
                    this._state.enabled = true;
                    this._toggle.checked = true;
                }
                t

All Versions

Version Status
1 Unreviewed