Review of "ClipQR" version 8

Details Page Preview

This simply adds a pop-out QR Code containing whatever text is currently in your clipboard. It's an easy way to share a link to your phone without any additional software.

Extension Homepage
https://github.com/drien/gnome-shell-extension-clipqr

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:77
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:65
          this.menu.connect('open-state-changed', (menu, open) => {
            if (!open) {
              if (file) {
                file.delete(null);
              }
              return;
            }
    
            qrWidget.visible = false;
            emptyItem.visible = false;
            tooBigItem.visible = false;
    
            St.Clip

All Versions

Version Status
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active