Review of "devs-bottom-dock" version 1

Details Page Preview

A beautiful auto-hide dock with glass effect, showing your favourite and running apps.

Extension Homepage
https://github.com/SayedZeeshanHyder/devs-bottom-dock

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 17 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:47
    console.log(`${TAG} ${message}`)
  • extension.js:52
    console.error('')
  • extension.js:53
    console.error('=================================================')
  • extension.js:54
    console.error(`${TAG} ERROR`)
  • extension.js:55
    console.error('=================================================')
  • extension.js:57
    console.error(`${TAG} ${message}`)
  • extension.js:60
    console.error(`${TAG} No error object`)
  • extension.js:61
    console.error('=================================================')
  • extension.js:67
    console.error(`${TAG} NAME: ${error.name}`)
  • extension.js:68
    console.error(`${TAG} MESSAGE: ${error.message}`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • .git/index
    .git/index
  • .git/description
    .git/description
  • .git/HEAD
    .git/HEAD
  • .git/config
    .git/config
  • .git/COMMIT_EDITMSG
    .git/COMMIT_EDITMSG
  • .git/hooks/pre-push.sample
    .git/hooks/pre-push.sample
  • .git/hooks/pre-merge-commit.sample
    .git/hooks/pre-merge-commit.sample
  • .git/hooks/pre-applypatch.sample
    .git/hooks/pre-applypatch.sample
  • .git/hooks/applypatch-msg.sample
    .git/hooks/applypatch-msg.sample
  • .git/hooks/post-update.sample
    .git/hooks/post-update.sample

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:293
                this._iconContainer =
                    new St.BoxLayout({
    
                        orientation:
                            Clutter.Orientation.HORIZONTAL,
    
                        reactive: true,
                    })
  • extension.js:252
                this._scrollView =
                    new St.ScrollView({
    
                        hscrollbar_policy:
                            St.PolicyType.NEVER,
    
                        vscrollbar_policy:
                            St.PolicyType.NEVER,
    
                        overlay_scrollbars: true,
    
                   

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:470
                this._hotEdge.connect(
                    'enter-event',
                    () => {
    
                        this._removeTimers();
    
                        if (!this._isVisible)
                            this._showDock();
                    }
                )
  • extension.js:318
                this._scrollView.connect(
                    'scroll-event',
                    (actor, event) => {
    
                        try {
    
                            const adjustment =
                                this._scrollView.hadjustment;
    
                            if (!adjustment)
                           

All Versions

Version Status
1 Unreviewed