Review of "OpenVPN3 Indicator" version 3

Details Page Preview

Control OpenVPN3 sessions and configs. Tags: vpn, openvpn, openvpn 3, network, security, indicator, applet, tray, top bar, connection

Extension Homepage
https://github.com/omid/gnome-shell-openvpn3-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
5 Active
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
Approved but 1. Duplicated code is a bad practice (`runCommand()` in both `prefs.js` and `extension.js`). Better to moved that function to a module and simply import it to both of those files. 2. Since you subprocess with dynamic values, it's always better to sanitize the value of `sessionPath` or `configName`.