Review "Battery Threshold" version 1 - GNOME Shell Extensions

Review of "Battery Threshold" version 1

Control laptop battery charge thresholds to prolong battery life. Supports standard sysfs, Xiaomi (acpi_call), ThinkPad, and more.

No comments.

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

EGO-P-001 error

GSettings schema id must use org.gnome.shell.extensions base

GSettings schema id must start with `org.gnome.shell.extensions`.

schemas/io.github.korrnals.BatteryThreshold.gschema.xml

id='io.github.korrnals.BatteryThreshold' path='/io/github/korrnals/battery-threshold/'

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

schemas/io.github.korrnals.BatteryThreshold.gschema.xml

id='io.github.korrnals.BatteryThreshold' path='/io/github/korrnals/battery-threshold/'

Version	Status
1	Unreviewed